[Tree] Fix TreeObjectHydrator, when $parent field is defined before $children field #2866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s defined before the child field in a tree structure.
phansys
added
Bug
jdigonnet
approved these changes
Feb 27, 2025
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
phansys
reviewed
Sep 20, 2025
There was a problem hiding this comment.
Thanks @mic-tilted!
Could you please add tests covering the problematic scenario and the corresponding entries in the changelog file? If this change is fixing a bug, this requires at least an entry in the Fixed section.
See: https://github.com/doctrine-extensions/DoctrineExtensions/blob/main/CONTRIBUTING.md#changelog.
phansys
added
the
Still Relevant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I followed the documentation https://github.com/doctrine-extensions/DoctrineExtensions/blob/main/doc/tree.md#building-trees-from-your-entities
And I'm encountering this error:
The error occurs when the $parent field is defined before $children in a Tree entity. I forked the repository and ran the tests, reversing the order of the fields in tests/Gedmo/Tree/Fixture/RootCategory.php, and I managed to reproduce the same error.